On 2022/03/25 16:12, Hannes Reinecke wrote: > On 3/25/22 04:01, Damien Le Moal wrote: >> On 3/24/22 21:32, Hannes Reinecke wrote: >>> Add a config option 'ATA_SYSFS_COMPAT' to create a compability >> >> s/compability/compatibility >> >>> 'ata' symlink in the PCI device sysfs directory. >> >> I am not yet convinced if this new config option is really necessary... >> We could create the symlink unconditionally, no ? >> > We could, but why? > The sole point of the compat symlink is to preserve compability with > previous releases. But we don't really know if this compatility really > is required; I haven't seen any difference in behaviour with or without > the symlinks. > By having a config option we make it clear that the symlinks will > eventually vanish. OK. The default is "y" for now anyway, so it is safe. > >> In any case, I would like to at least reduce the number of #ifdef. So >> what about something like this on top of your patch: >> > Sure. Will be doing so in the next round. > > Cheers, > > Hannes -- Damien Le Moal Western Digital Research
