On 2022/03/21 19:43, Andy Shevchenko wrote:
> On Mon, Mar 21, 2022 at 11:00:51AM +0300, Sergey Shtylyov wrote:
>> On 3/19/22 11:11 PM, Christian Lamparter wrote:
>
> ...
>
>>> + { "Samsung SSD 840 EVO*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
>>> + ATA_HORKAGE_NO_DMA_LOG |
>>> + ATA_HORKAGE_ZERO_AFTER_TRIM, },
>>> { "Samsung SSD 840*", NULL, ATA_HORKAGE_NO_NCQ_TRIM |
>>> ATA_HORKAGE_ZERO_AFTER_TRIM, },
>>
>> Shouldn't this entry be modified instead?
>
> Wouldn't it modify much more devices with unknown outcome?
> I would be on the safer side as done by this patch.
>
Yes, I think so too. A little googling shows that there are "840 xxx", "840 PRO
xxx" and "840 EVO xxx", at least as product names. Not sure how all these are
grouped with the actual device reported model.
--
Damien Le Moal
Western Digital Research
