Hi
> Gesendet: Mittwoch, 02. März 2022 um 10:46 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxxxxx>
> On 01/03/2022 16:24, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - brcm,iproc-ahci
> > + - marvell,armada-8k-ahci
> > + - marvell,berlin2q-ahci
> > + - const: generic-ahci
> > + - enum:
> > + - brcm,iproc-ahci
>
> This one is already earlier in generic-ahci, so you can skip him here.
OK, i drop it
> > + - cavium,octeon-7130-ahci
> > + - hisilicon,hisi-ahci
> > + - ibm,476gtr-ahci
> > + - marvell,armada-3700-ahci
> > + - marvell,armada-380-ahci
> > + - snps,dwc-ahci
> > + - snps,spear-ahci
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description:
> > + Clock IDs array as required by the controller.
> > + minItems: 1
> > + maxItems: 3
> > +
> > + interrupts:
> > + description:
> > + specifies the interrupt number for the controller.
>
> Skip description, it's obvious.
OK
> > + maxItems: 1
> > +
> > + ahci-supply:
> > + description:
> > + regulator for AHCI controller
> > +
> > + clock-names:
> > + description:
> > + Names of clocks corresponding to IDs in the clock property.
> > + minItems: 1
> > + maxItems: 3
>
> Put the clock-names next to clocks.
had moved them down as they are optional, but ok, i move up
> > +
> > + dma-coherent:
> > + true
>
> New line not needed. "dma-coherent: true"
OK
> > + ports-implemented:
> > + $ref: '/schemas/types.yaml#/definitions/uint32'
> > + description:
> > + Mask that indicates which ports that the HBA supports
> > + are available for software to use. Useful if PORTS_IMPL
> > + is not programmed by the BIOS, which is true with
> > + some embedded SoCs.
> > + maxItems: 1
>
> maxItems are incorrect here, this is not an array.
right, i'll change it
> > +patternProperties:
> > + "^sata-port@[0-9a-f]+$":
> > + type: object
> > + description:
> > + Subnode with configuration of the Ports.
> > +
> > + properties:
> > + reg:
> > + maxItems: 1
> > +
> > + phys:
> > + minItems: 1
>
> maxItems: 1
oh, missed that
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/berlin2q.h>
> > + sata@f7e90000 {
> > + compatible = "marvell,berlin2q-ahci", "generic-ahci";
> > + reg = <0xe90000 0x1000>;
>
> You still have wrong address.
only took the example from the txt, but i guess reg should be <0xf7e90000 0x1000>; ?
will also fix all subjects to
"dt-bindings: ata: ahci-platform: ..."
Thanks
