`AHCI_HFLAG_IS_MOBILE` designates that a chipset should be using the default link power management policy from a kernel configuration item. As desktop chipsets may also be interested in this default policy configuration, rename the flag to `AHCI_HFLAG_USE_LPM_POLICY` to more accurately reflect that a chipset doesn't have to be mobile to adopt it. Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> --- Changes from v2->v3 * Add tags drivers/ata/ahci.c | 6 +++--- drivers/ata/ahci.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 8f38244eda23..3a6db73d28d0 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -136,7 +136,7 @@ static const struct ata_port_info ahci_port_info[] = { .port_ops = &ahci_ops, }, [board_ahci_low_power] = { - AHCI_HFLAGS (AHCI_HFLAG_IS_MOBILE), + AHCI_HFLAGS (AHCI_HFLAG_USE_LPM_POLICY), .flags = AHCI_FLAG_COMMON, .pio_mask = ATA_PIO4, .udma_mask = ATA_UDMA6, @@ -1595,8 +1595,8 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap, int policy = CONFIG_SATA_MOBILE_LPM_POLICY; - /* Ignore processing for non mobile platforms */ - if (!(hpriv->flags & AHCI_HFLAG_IS_MOBILE)) + /* Ignore processing for chipsets that don't use policy */ + if (!(hpriv->flags & AHCI_HFLAG_USE_LPM_POLICY)) return; /* user modified policy via module param */ diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h index eeac5482f1d1..1ad48e2fe573 100644 --- a/drivers/ata/ahci.h +++ b/drivers/ata/ahci.h @@ -235,7 +235,7 @@ enum { AHCI_HFLAG_YES_ALPM = (1 << 23), /* force ALPM cap on */ AHCI_HFLAG_NO_WRITE_TO_RO = (1 << 24), /* don't write to read only registers */ - AHCI_HFLAG_IS_MOBILE = (1 << 25), /* mobile chipset, use + AHCI_HFLAG_USE_LPM_POLICY = (1 << 25), /* chipset that should use SATA_MOBILE_LPM_POLICY as default lpm_policy */ AHCI_HFLAG_SUSPEND_PHYS = (1 << 26), /* handle PHYs during -- 2.34.1