On 2/20/22 05:04, Sergey Shtylyov wrote:
> The f_CNT register (at the PCI config. address 0x78) is 16-bit, not 8-bit!
> The bug was there from the very srart... :-(
>
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
Any Fixes tag possible with this one ? I have not checked what "git
blame" says...
>
> ---
> This patch is against the 'master' branch of Damien Le Moal's 'libata.git'
> repo.
>
> drivers/ata/pata_hpt37x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: libata/drivers/ata/pata_hpt37x.c
> ===================================================================
> --- libata.orig/drivers/ata/pata_hpt37x.c
> +++ libata/drivers/ata/pata_hpt37x.c
> @@ -950,14 +950,14 @@ static int hpt37x_init_one(struct pci_de
>
> if ((freq >> 12) != 0xABCDE) {
> int i;
> - u8 sr;
> + u16 sr;
> u32 total = 0;
>
> dev_warn(&dev->dev, "BIOS has not set timing clocks\n");
>
> /* This is the process the HPT371 BIOS is reported to use */
> for (i = 0; i < 128; i++) {
> - pci_read_config_byte(dev, 0x78, &sr);
> + pci_read_config_word(dev, 0x78, &sr);
> total += sr & 0x1FF;
> udelay(15);
> }
>
--
Damien Le Moal
Western Digital Research
