On 2/14/22 2:25 AM, Damien Le Moal wrote: >> Commit 41dec29bcb05 ("libata: introduce sff_set_devctl() method") left some >> clumsy checks surrounding calls to ata_sff_set_devctl() which Jeff Garzik >> suggested to factor out... and I never followed up. :-( >> >> At last, refactor ata_sff_set_devctl() to include the repetitive checks and >> return a 'bool' result indicating if the device control register exists or >> not. >> >> While at it, further update the 'kernel-doc' comment -- the device control >> register has never been a part of the taskfile, despite what Jeff and co. >> think! :-) >> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > > This patch has "v2"... I do not recall seeing a v1 and the cover letter has no > changelog (and no v2 tag)... Is this a new series ? That v2 is there by mistake, please ignore it. [...] MBR, Sergey