On 2/7/22 15:50, Hannes Reinecke wrote:
> On 2/7/22 04:16, Damien Le Moal wrote:
>> The concurrent positioning ranges log page 47h is a general purpose log
>> page and not a subpage of the indentify device log. Using
>> ata_identify_page_supported() to test for concurrent positioning ranges
>> support is thus wrong. ata_log_supported() must be used.
>> This invalid test created boot problems for several users in the field.
>>
>> While at it, strengthen the detection for concurrent positioning ranges
>> support by limiting the detection to drives implementing a recent ATA
>> standard, that is, ACS-4 (major version 11) or later ACS versions. This
>> additional condition effectively turns ata_dev_config_cpr() into a nop,
>> avoiding problems in the field with older drives.
>>
>> Fixes: fe22e1c2f705 ("libata: support concurrent positioning ranges log")
>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215519
>> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/ata/libata-core.c | 19 ++++++++++---------
>> 1 file changed, 10 insertions(+), 9 deletions(-)
>>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
Thanks, but I sent a v3 with an update to include/linux/ata.h. Review OK
on that one ?
>
> Cheers,
>
> Hannes
--
Damien Le Moal
Western Digital Research
