On 2/2/22 05:50, Sergey Shtylyov wrote: > Since the commit c05e6ff035c1b25d17364a685432 ("libata-acpi: implement > and use ata_acpi_init_gtm()") ata_acpi_on_suspend() just returns 0, so > its call from ata_eh_handle_port_suspend() doesn't make sense anymore. > Remove the function completely, at last... > > Found by Linux Verification Center (linuxtesting.org) with the SVACE static > analysis tool. > > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > > --- > This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git' > repo. > > Changes in version 2: > - added the 'drivers/ata/libata.h' file update. > > drivers/ata/libata-acpi.c | 21 --------------------- > drivers/ata/libata-eh.c | 7 +------ > drivers/ata/libata.h | 2 -- > 3 files changed, 1 insertion(+), 29 deletions(-) Applied to for-5.18 with a small change to the patch title: ata: libata-ahci: kill ata_acpi_on_suspend() Thanks ! -- Damien Le Moal Western Digital Research