Hi Sergey, Thank you for the review. On Mon, Dec 27, 2021 at 7:58 PM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote: > > On 12/24/21 4:12 PM, Lad Prabhakar wrote: > > > To be consistent with pata_of_platform driver use > > platform_get_irq_optional() instead of > > platform_get_resource(pdev, IORESOURCE_IRQ, 0). > > But why can't we be consistent with the unpatched pata_of_platfrom(), and then > convert to platform_get_irq_optional() after merging both drivers? > I'd like to avoid patching the driver to be gone if possible... > Basically to have members of struct pata_platform_priv{} in one shot, instead of changing them again and again. btw you are OK with patching for 06/10. Cheers, Prabhakar