Hello!
On 21.12.2021 10:21, Hannes Reinecke wrote:
Convert the sole caller to ata_dev_deb() and remove the definition.
ata_dev_info() actually (as follows from the patch)?
Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
---
drivers/ata/libata-core.c | 10 +++-------
include/linux/libata.h | 2 --
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index dcb3278471fb..81ea8241fdba 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2530,8 +2530,8 @@ int ata_dev_configure(struct ata_device *dev)
char modelbuf[ATA_ID_PROD_LEN+1];
int rc;
- if (!ata_dev_enabled(dev) && ata_msg_info(ap)) {
- ata_dev_info(dev, "%s: ENTER/EXIT -- nodev\n", __func__);
+ if (!ata_dev_enabled(dev)) {
+ ata_dev_dbg(dev, "no device\n");
return 0;
}
@@ -5333,11 +5333,7 @@ struct ata_port *ata_port_alloc(struct ata_host *host)
#if defined(ATA_VERBOSE_DEBUG)
/* turn on all debugging levels */
- ap->msg_enable = 0x0003;
-#elif defined(ATA_DEBUG)
- ap->msg_enable = ATA_MSG_DRV | ATA_MSG_INFO;
-#else
- ap->msg_enable = ATA_MSG_DRV;
+ ap->msg_enable = 0x0001;
#endif
mutex_init(&ap->scsi_scan_mutex);
diff --git a/include/linux/libata.h b/include/linux/libata.h
index bce3b50112c0..9895414492cb 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -73,11 +73,9 @@
enum {
ATA_MSG_DRV = 0x0001,
- ATA_MSG_INFO = 0x0002,
};
#define ata_msg_drv(p) ((p)->msg_enable & ATA_MSG_DRV)
-#define ata_msg_info(p) ((p)->msg_enable & ATA_MSG_INFO)
static inline u32 ata_msg_init(int dval, int default_msg_enable_bits)
{
MBR, Sergey