On 12/9/21 10:22 PM, Andy Shevchenko wrote: [...] >>>>> No need to repeat this. >>>>> >>>>> While at it, drop redundant check for 0 as platform_get_irq() spills >>>>> out a big WARN() in such case. >>>> >>>> And? IRQ0 is still returned! :-( >>> >>> It should not be returned in the first place. >> >> But it still is, despite the WARN(), right? > > So, you admit that there is a code which does that? I admit *what*?! That platfrom_get_irq() and its ilk return IRQ0 while they shouldn't? =) > That code should be fixed first. Have you sent a patch? Which code?! You got me totally muddled. =) > ... > >>>>> - if (!irq) >>>>> - return -EINVAL; >>>> >>>> This is prermature -- let's wait till my patch that stops returning IRQ0 from >>>> platform_get_irq() and friends gets merged.... >>> >>> What patch? >> >> https://marc.info/?l=linux-kernel&m=163623041902285 >> >>> Does it fix platform_get_irq_optional()? >> >> Of course! :-) > > Can you share link to lore.kernel.org, please? > It will make much easier to try and comment. I don't know how to uise it yet, and I'm a little busy with other IRQ0 issues ATM, so I'm afraid you're on your own here... MBR, Sergey
