Re: [PATCH 33/73] pata_octeon_cf: Drop pointless VPRINTK() calls and convert the remaining ones

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08.12.2021 19:32, Hannes Reinecke wrote:

Drop pointless VPRINTK() calls for entering and existing interrupt

   s/existing/exiting/?
BTW, I'm not seeing where you drop VPRINTK() calls in the interrupt handlers...

routines and convert the remaining calls to dev_dbg().

Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
---
  drivers/ata/pata_octeon_cf.c | 23 ++---------------------
  1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index 7b80bbd9b1ed..de27428920a0 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
[...]
@@ -617,9 +599,8 @@ static unsigned int octeon_cf_dma_finished(struct ata_port *ap,
  	union cvmx_mio_boot_dma_intx dma_int;
  	u8 status;
- VPRINTK("ata%u: protocol %d task_state %d\n",
-		ap->print_id, qc->tf.protocol, ap->hsm_task_state);
-
+	ata_port_dbg(ap, "protocol %d task_state %d\n",
+		     qc->tf.protocol, ap->hsm_task_state);

   You are replacing VPRINTK() here, not removing...

[...]

MBR, Sergey



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux