Re: [PATCH 69/73] pata_octeon_cf: Replace pr_XXX() calls with structured logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 08.12.2021 19:32, Hannes Reinecke wrote:

Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
---
  drivers/ata/pata_octeon_cf.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index de27428920a0..64bb65ef8f02 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -273,9 +273,9 @@ static void octeon_cf_set_dmamode(struct ata_port *ap, struct ata_device *dev)
  	dma_tim.s.we_n = ns_to_tim_reg(tim_mult, oe_n);
  	dma_tim.s.we_a = ns_to_tim_reg(tim_mult, oe_a);
- pr_debug("ns to ticks (mult %d) of %d is: %d\n", tim_mult, 60,
+	ata_dev_dbg(dev, "ns to ticks (mult %d) of %d is: %d\n", tim_mult, 60,
  		 ns_to_tim_reg(tim_mult, 60));

   Shouldn't you realign this like with the moved ( above?

-	pr_debug("oe_n: %d, oe_a: %d, dmack_s: %d, dmack_h: %d, dmarq: %d, pause: %d\n",
+	ata_dev_dbg(dev, "oe_n: %d, oe_a: %d, dmack_s: %d, dmack_h: %d, dmarq: %d, pause: %d\n",
  		 dma_tim.s.oe_n, dma_tim.s.oe_a, dma_tim.s.dmack_s,
  		 dma_tim.s.dmack_h, dma_tim.s.dmarq, dma_tim.s.pause);

   Same here.

MBR, Sergey



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux