On 2021/11/09 17:54, Christoph Hellwig wrote: > On Tue, Nov 09, 2021 at 08:57:23AM +0900, Damien Le Moal wrote: >> ACS defines the ATA Identify Device Data log as mandatory. A warning >> message currently signals to the user if a device does not report >> supporting this log page in the log directory page. However, it is >> useless to constantly access the log directory and warn about this lack >> of support once we have discovered that the device does not support >> this mandatory log page. >> >> Introduce the horkage flag ATA_HORKAGE_NO_ID_DEV_LOG to mark a device as >> lacking support for the Identify Device Data log page. Set this flag >> when ata_log_supported() returns false in ata_identify_page_supported(). >> The warning is printed only once on device scan and the log directory >> not accessed again to test for Identify Device Data log page support. > > Should we also just set it by default for older devices? I'd need to > look up when it was introduced, but I think it is a somewhat recent > addition. It is marked as mandatory at least since ACS-3. Need to check before that. Will do. -- Damien Le Moal Western Digital Research
