On 2021/10/21 17:37, Sergey Shtylyov wrote: > On 21.10.2021 8:57, Zheyu Ma wrote: > >> mv_init_host() propagates the value returned by mv_chip_id() which in turn >> gets propagated by mv_pci_init_one() and hits local_pci_probe(). >> >> During the process of driver probing, the probe function should return < 0 >> for failure, otherwise, the kernel will treat value > 0 as success. >> >> Signed-off-by: Zheyu Ma <zheyuma97@xxxxxxxxx> >> --- >> drivers/ata/sata_mv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c >> index 9d86203e1e7a..7461fe078dd1 100644 >> --- a/drivers/ata/sata_mv.c >> +++ b/drivers/ata/sata_mv.c >> @@ -3897,7 +3897,7 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx) >> >> default: >> dev_err(host->dev, "BUG: invalid board index %u\n", board_idx); >> - return 1; >> + return -ENODEV; > > Doesn't -EINVAL fit better here? If the error message is correct and this can only happen if there is a bug somewhere, I do not think the error code really matters much. The dev_err() should probably be changed to dev_alert() or even dev_crit() for this case. > > [...] > > MBR, Sergey > -- Damien Le Moal Western Digital Research
