Re: [PATCH] scsi: ata: make ahci_sdev_attrs static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/19/21 15:44, Damien Le Moal wrote:
+Bart

On 2021/10/19 19:24, Jiapeng Chong wrote:
From: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx>

The patch title should be:

ata: libahci: make ahci_sdev_attrs static


This symbol is not used outside of libahci.c, so marks it static.

Fix the following sparse warning:

drivers/ata/libahci.c:134:18: warning: symbol 'ahci_sdev_attrs' was not
declared. Should it be static?

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
Signed-off-by: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx>
---
  drivers/ata/libahci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 28430c093a7f..8a6835bfd18a 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
  };
  EXPORT_SYMBOL_GPL(ahci_shost_groups);
-struct attribute *ahci_sdev_attrs[] = {
+static struct attribute *ahci_sdev_attrs[] = {
  	&dev_attr_sw_activity.attr,
  	&dev_attr_unload_heads.attr,
  	&dev_attr_ncq_prio_supported.attr,


Looks OK to me.

The above patch looks fine to me too.

Thanks,

Bart.



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux