Re: [PATCH v2] Add AHCI support for ASM1062+JBM575 cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021/10/12 6:04, István Pongrácz wrote:
> Add support for PCIe SATA expander cards based on ASMedia 1062 + JBM575
> controllers.
> These cards can provide up to 10 or more SATA ports on one PCIe card.
> 
> Signed-off-by: István Pongrácz <pongracz.istvan@xxxxxxxxx>
> ---
>  drivers/ata/ahci.c | 1 +
>  1 file changed, 1 insertion(+)
>  Changes from v1: rework commit message to meet syntax and content requirements.

Almost ! This line must be the first one after "---" And put a blank line after
it. After that, it is the patch proper. It should look like:

...
Signed-off-by: István Pongrácz <pongracz.istvan@xxxxxxxxx>
---
Changes from v1: rework commit message to meet syntax and content requirements.

 drivers/ata/ahci.c | 1 +
 1 file changed, 1 insertion(+)
...


Apart from that, this looks good.

> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ea..97fd96b67731 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>  	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
> +	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci },   /* ASM1062+JMB575 */
>  
>  	/*
>  	 * Samsung SSDs found on some macbooks.  NCQ times out if MSI is
> 


-- 
Damien Le Moal
Western Digital Research





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux