On 2021/10/11 17:59, István Pongrácz wrote:
Your commit title is too lon. Shorten it to:
Add AHCI support for ASM1062+JBM575 cards
And then add a commit message with the details (PCIe card, usually 10 ports,
etc. Whatever information is relevant to describe the hardware.
Also please sign your patch (Add a Signed-off-by: xxx tag). You can do this
automatically by doing a "git commit -s" when creating your patch.
> ---
> drivers/ata/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ea..f8199f021ed4 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
> { PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
> { PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci }, /* ASM1061R */
> { PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci }, /* ASM1062R */
> + { PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, /* ASMedia Technology Inc. Device 0624 (rev 01) based PCIe port multiplier cards (ex. 10 ports card with 1 x ASM1062 + 2 x JMB575 */
Line too long. Please shorten the comment to /* ASM1062+JMB575 */
>
> /*
> * Samsung SSDs found on some macbooks. NCQ times out if MSI is
>
--
Damien Le Moal
Western Digital Research
