On Mon, Sep 20, 2021 at 9:45 AM Fabio Estevam <festevam@xxxxxxxxx> wrote: > > Hi Sergey, > > On Sat, Sep 18, 2021 at 5:49 PM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote: > > > > IMHO the current code is correct as-is. > > > > Not quite... I don't want to leave a bad example for the future driver authors. What should > > I change in the patch description for the patch to become acceptable for you? > > Please see how the PCI subsystem has converted the handling of > platform_get_irq(): > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5 > > Why does drivers/ata/ need to handle platform_get_irq() differently? > > I still don't see the need for changing drivers/ata/pata_imx.c in this aspect. Also, please check this commit too: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=a85a6c86c25be2d2a5f9c31491f612ce0edc7869
