Hi Tor, On 9/19/21 4:24 PM, Tor Vic wrote: > Hi, > > I saw that v2 (?) of this patch has made it into stable, which > is quite reasonable given the number of bug reports. > Are there any plans to "enhance" this patch once sufficient data > on controller support/drive combinations has been collected? ATM there are no plans to limit these quirks, we have bug reports of queued trims being an issue over all usual chip-vendors of sata controllers (including more recent AMD models). Note that unless you have immediate "discard" enabled as an option on all layers of your storage stack (dmcrypt, device-mapper/raid, filesystem) then this change will not impact you at all. Also note that AFAIK all major distros do not enable immediate discard, instead relying on fstrim runs from a cronjob, which again means this change will not impact users of those distros. So chances are that your workload simply never triggered the issue; and this is the cause of everything always having worked fine for you. Regards, Hans
