Hi, On 9/19/21 11:43 AM, Krzysztof Kozlowski wrote: > Intel devices 0x2822, 0x2823, 0x2826 and 0x2827 are already on the list > as Lewisburg AHCI/RAID. They use same configuration except 0x2822 which > has board_ahci_nosntf (for ICH8). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > > --- > > Not tested. > > Changes since v1: > 1. Use still board_ahci_nosntf for 0x2822. > --- > drivers/ata/ahci.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index 186cbf90c8ea..63198ad95ed9 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -258,7 +258,7 @@ static const struct pci_device_id ahci_pci_tbl[] = { > { PCI_VDEVICE(INTEL, 0x2683), board_ahci }, /* ESB2 */ > { PCI_VDEVICE(INTEL, 0x27c6), board_ahci }, /* ICH7-M DH */ > { PCI_VDEVICE(INTEL, 0x2821), board_ahci }, /* ICH8 */ > - { PCI_VDEVICE(INTEL, 0x2822), board_ahci_nosntf }, /* ICH8 */ > + { PCI_VDEVICE(INTEL, 0x2822), board_ahci_nosntf }, /* ICH8/Lewisburg RAID*/ > { PCI_VDEVICE(INTEL, 0x2824), board_ahci }, /* ICH8 */ > { PCI_VDEVICE(INTEL, 0x2829), board_ahci }, /* ICH8M */ > { PCI_VDEVICE(INTEL, 0x282a), board_ahci }, /* ICH8M */ > @@ -316,7 +316,7 @@ static const struct pci_device_id ahci_pci_tbl[] = { > { PCI_VDEVICE(INTEL, 0x1d02), board_ahci }, /* PBG AHCI */ > { PCI_VDEVICE(INTEL, 0x1d04), board_ahci }, /* PBG RAID */ > { PCI_VDEVICE(INTEL, 0x1d06), board_ahci }, /* PBG RAID */ > - { PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG RAID */ > + { PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* PBG/Lewisburg RAID*/ > { PCI_VDEVICE(INTEL, 0x2323), board_ahci }, /* DH89xxCC AHCI */ > { PCI_VDEVICE(INTEL, 0x1e02), board_ahci }, /* Panther Point AHCI */ > { PCI_VDEVICE(INTEL, 0x1e03), board_ahci_mobile }, /* Panther M AHCI */ > @@ -358,8 +358,8 @@ static const struct pci_device_id ahci_pci_tbl[] = { > { PCI_VDEVICE(INTEL, 0x1f37), board_ahci_avn }, /* Avoton RAID */ > { PCI_VDEVICE(INTEL, 0x1f3e), board_ahci_avn }, /* Avoton RAID */ > { PCI_VDEVICE(INTEL, 0x1f3f), board_ahci_avn }, /* Avoton RAID */ > - { PCI_VDEVICE(INTEL, 0x2823), board_ahci }, /* Wellsburg RAID */ > - { PCI_VDEVICE(INTEL, 0x2827), board_ahci }, /* Wellsburg RAID */ > + { PCI_VDEVICE(INTEL, 0x2823), board_ahci }, /* Wellsburg/Lewisburg AHCI*/ > + { PCI_VDEVICE(INTEL, 0x2827), board_ahci }, /* Wellsburg/Lewisburg RAID*/ > { PCI_VDEVICE(INTEL, 0x43d4), board_ahci }, /* Rocket Lake PCH-H RAID */ > { PCI_VDEVICE(INTEL, 0x43d5), board_ahci }, /* Rocket Lake PCH-H RAID */ > { PCI_VDEVICE(INTEL, 0x43d6), board_ahci }, /* Rocket Lake PCH-H RAID */ > @@ -394,10 +394,6 @@ static const struct pci_device_id ahci_pci_tbl[] = { > { PCI_VDEVICE(INTEL, 0xa106), board_ahci }, /* Sunrise Point-H RAID */ > { PCI_VDEVICE(INTEL, 0xa107), board_ahci_mobile }, /* Sunrise M RAID */ > { PCI_VDEVICE(INTEL, 0xa10f), board_ahci }, /* Sunrise Point-H RAID */ > - { PCI_VDEVICE(INTEL, 0x2822), board_ahci }, /* Lewisburg RAID*/ > - { PCI_VDEVICE(INTEL, 0x2823), board_ahci }, /* Lewisburg AHCI*/ > - { PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* Lewisburg RAID*/ > - { PCI_VDEVICE(INTEL, 0x2827), board_ahci }, /* Lewisburg RAID*/ > { PCI_VDEVICE(INTEL, 0xa182), board_ahci }, /* Lewisburg AHCI*/ > { PCI_VDEVICE(INTEL, 0xa186), board_ahci }, /* Lewisburg RAID*/ > { PCI_VDEVICE(INTEL, 0xa1d2), board_ahci }, /* Lewisburg RAID*/ >