On 2021/09/07 2:38, Jens Axboe wrote: > On 9/5/21 7:58 PM, Damien Le Moal wrote: >> struct blk_independent_access_ranges contains kobjects (struct kobject) >> to expose to the user through sysfs the set of independent access ranges >> supported by a device. When the device is initialized, sysfs >> registration of the ranges information is done from blk_register_queue() >> using the block layer internal function disk_register_iaranges(). If a >> driver calls disk_set_iaranges() for a registered queue, e.g. when a >> device is revalidated, disk_set_iaranges() will execute >> disk_register_iaranges() to update the sysfs attribute files. > > I really detest the iaranges "name", it's horribly illegible. If you > want to stick with the ia thing, then disk_register_ia_ranges() would be > a lot better (though still horrible, imho, just less so). For the function names, similarly with the struct names, I can use the full spelling, so disk_set_independent_access_ranges() and disk_alloc_independent_access_ranges(). Same for the internal functions for sysfs registration. Longer function names, but very clear I think. > > Same goes for blk-iaranges, we really need to come up with something > more descriptive here. OK. I can rename the file to block/blk-independent-access-ranges.c. It is a long but clear. Are you OK with shortened local variable names in that file ? Using the full spelling make formatting of the code really hard due to the very long lines. -- Damien Le Moal Western Digital Research
