On 01.09.21 09:38, Hans de Goede wrote: > Hi, > > On 9/1/21 10:55 AM, Hans de Goede wrote: >> Hi Tor, >> >> On 9/1/21 9:37 AM, torvic9@xxxxxxxxxxx wrote: >>> (Sorry for not doing a proper reply) >>> >>> Hello, >>> Noob here. >>> I have a Samsung 860 Pro connected to a AMD X570 chipset mainboard and >>> it just works flawlessly on 5.13 and 5.14. >>> Are you sure that *every* 860/870 is concerned by this problem on >>> *every* AMD controller? >> >> I am pretty sure that every 860 / 870 EVO is affected, >> I am not sure if the PRO is also affected. > > So while reading https://bugzilla.kernel.org/show_bug.cgi?id=201693 > again to add a comment asking if anyone was seeing this on a > pro to I found existing comments of both queued-trims being > an issue on the 860 pro, as well as the 860 pro having issues > with some AMD sata controllers. > > So it seems safe to say that the 860 pro has the same issues > as the 860 and 870 evo models. Chances are you don't have > discard support enabled causing you to not see the queued-trim > issues (which means you also won't see any difference from > disabling support for queued-trim commands). > > So this just leaves your question of: > > "concerned by this problem on *every* AMD controller?" > > Where "this problem" is needing to completely disable NCQ > and I guess the answer is no, not every AMD controller > is affected. Still the plan is to err on the safe side for now, > allowing overriding this from the kernel cmdline with: > > libata.force=ncqamd > > I will add a comment to: > > https://bugzilla.kernel.org/show_bug.cgi?id=201693 > > Asking for PCI-ids of the controllers where people are seeing > this and then maybe we can narrow down the "AMD" check in a > future follow up patch. $ lspci -nn | grep -i sata 06:00.0 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD] FCH SATA Controller [AHCI mode] [1022:7901] (rev 51) 07:00.0 SATA controller [0106]: Advanced Micro Devices, Inc. [AMD] FCH SATA Controller [AHCI mode] [1022:7901] (rev 51) Both Samsung 860 Pro and 860 Evo are connected to these. > > Regards, > > Hans >
