Hi, On 8/30/21 11:45 PM, Damien Le Moal wrote: > On 2021/08/30 23:43, Kate Hsuan wrote: >> Many users reported the issue when running the system with Samsung 860, >> 870 SSD, and AMD chipset. Therefore, completely disabling the NCQ can >> avoid this issue. >> >> Entire disabling NCQ for Samsung 860/870 SSD will cause I/O performance >> drop. In this case, a flag ATA_HORKAGE_NONCQ_ON_AMD is introduced to >> used to perform an additional check for these SSDs. If it finds its parent >> ATA controller is AMD, the NCQ will be disabled. Otherwise, the NCQ is kept >> to enable. > > For a single patch, generally, a cover letter is not needed. Especially so in > this case since your cover letter message is the same as the patch commit message. > >> >> Changes since v3 >> * Modified the flag from ATA_HORKAGE_NONCQ_ON_ASMEDIA_AMD_MARVELL to >> ATA_HORKAGE_NONCQ_ON_AMD. >> * Modified and fixed the code to completely disable NCQ on AMD controller. > > Technically, this is a v2 right ? Also, by "completely", did you mean "always" ? > (see patch comments). Right, as mentioned in my reply to the v1 which was accidentally labelled v2 I suggested to just make this v3 to avoid confusion, otherwise we would have 2 v2-s. Regards, Hans
