On Jun 10 2021, Michael Schmitz wrote: > Hi Andreas, > > On 9/06/21 8:04 pm, Andreas Schwab wrote: >> On Jun 09 2021, Michael Schmitz wrote: >> >>> @@ -136,6 +141,9 @@ static inline u8 __iomem *isa_itb(unsigned long addr) >>> case ISA_TYPE_Q40: return (u8 __iomem *)Q40_ISA_IO_B(addr); >>> #endif >>> #ifdef CONFIG_AMIGA_PCMCIA >>> +#ifdef CONFIG_APNE100MBIT >>> + case ISA_TYPE_AG16: fallthrough; >>> +#endif >>> case ISA_TYPE_AG: return (u8 __iomem *)AG_ISA_IO_B(addr); >> Is the fallthrough annotation really needed? > > Just to shut up compiler warnings, and even that I haven't seen myself. If there is no warning, there is nothing to shut up. > In this particular case, there can be no doubt that the fallthrough is > intentional, so on balance, I'll remove those annotations as well > (unless Finn strongly objects?). There is no fallthrough, because there is no code. Andreas. -- Andreas Schwab, schwab@xxxxxxxxxxxxxx GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
