Re: [PATCH v2] m68k: io_mm.h: conditionalize ISA address translation on Atari

[Andreas Schwab <schwab@xxxxxxxxxxxxxx>]

On Jun 09 2021, Michael Schmitz wrote:

> @@ -135,10 +139,13 @@ static inline u8 __iomem *isa_itb(unsigned long addr)
>      case ISA_TYPE_AG: return (u8 __iomem *)AG_ISA_IO_B(addr);
>  #endif
>  #ifdef CONFIG_ATARI_ROM_ISA
> -    case ISA_TYPE_ENEC: return (u8 __iomem *)ENEC_ISA_IO_B(addr);
> +    case ISA_TYPE_ENEC:
> +	if (addr < 1024)
> +		return (u8 __iomem *)ENEC_ISA_IO_B(addr);
> +	break; /* not ROM port? fallback below! */
>  #endif
> -    default: return NULL; /* avoid warnings, just in case */
>      }
> +    return (u8 __iomem *)(addr); /* avoid warnings, just in case */

I don't think the comment still fits here.

Andreas.

-- 
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."