Hello!
On 15.03.2021 5:39, Wang Qing wrote:
platform_get_irq() has already checked and printed the return value,
the printing here is nothing special, and should corrected to < 0.
Also, thhe return value should return a real error.
The.
It's a bad idea to mix the fix and cleanup in one patch (and to do two
things in one patch as well); also describing a bug fix as an "appendage"
to the clean up. Anyway, I had already posted the fix here:
https://marc.info/?l=linux-ide&m=161575450917827
Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
---
drivers/ata/sata_highbank.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index 64b2ef1..4438ee6
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -469,10 +469,8 @@ static int ahci_highbank_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
- dev_err(dev, "no irq\n");
- return -EINVAL;
- }
+ if (irq < 0)
+ return irq;
What about irq == 0?
[...]
MBR, Sergei
