On 2/9/21 4:32 PM, Christoph Hellwig wrote: > On Tue, Feb 09, 2021 at 04:10:13PM +0800, Jeffle Xu wrote: >> While the whole block layer has migrated to mq framework, >> QUEUE_FLAG_ADD_RANDOM is not included in QUEUE_FLAG_MQ_DEFAULT as the >> default flags. > > If you are using the legacy ide code anywhere please switch to libata > ASAP as it is about to go away. > Thanks for replying. I have not encountered any trouble in reality world. Actually I just find that this code can't work well when I'm search QUEUE_FLAG_ADD_RANDOM. I'm not familiar with ide world. Please let me know if I miss something. Also there are several device drivers still calling 'blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, q)', though they have migrated to mq and have no need clearing QUEUE_FLAG_ADD_RANDOM. -- Thanks, Jeffle
