On 12/16/20 1:41 PM, Jim Quinlan wrote: > From: Jim Quinlan <jquinlan@xxxxxxxxxxxx> > > This driver may use one of two resets controllers. Keep them in separate > variables to keep things simple. The reset controller "rescal" is shared > between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. Use > devm_reset_control_get_optional_shared() to handle this sharing. > > Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting") > Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller name") > Signed-off-by: Jim Quinlan <jquinlan@xxxxxxxxxxxx> Thanks a lot for fixing this Jim, given the reset lines are still mutually exclusive the single variable along with the 7216 versus another chip differentiation would still work, but I have no objection to the approach you have taken: Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx> -- Florian