Today users have no easy way to correlate kernel log messages for storage
devices across reboots, device dynamic add/remove, or when the device is
physically or logically moved from from system to system. This is due
to the existing log IDs which identify how the device is attached and not
a unique ID of what is attached. Additionally, even when the attachment
hasn't changed, it's not always obvious which messages belong to the
device as the different areas in the storage stack use different
identifiers, eg. (sda, sata1.00, sd 0:0:0:0).
This change addresses this by adding a unique ID to each log
message. It couples the existing structured key/value logging capability
and VPD 0x83 device identification. The structured key/value data is not
visible in normal viewing and is not seen in the dmesg output or journal
output unless you go looking for it by dumping the output as JSON.
Some examples of logs filtered for a specific device utilizing this patch
series.
$ journalctl -b _KERNEL_DURABLE_NAME="`cat /sys/block/sdb/device/wwid`"
| cut -c 25- | fmt -t
l: scsi 1:0:0:0: Attached scsi generic sg1 type 0
l: sd 1:0:0:0: [sdb] 209715200 512-byte logical blocks: (107 GB/100 GiB)
l: sd 1:0:0:0: [sdb] Write Protect is off
l: sd 1:0:0:0: [sdb] Mode Sense: 00 3a 00 00
l: sd 1:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't
support DPO or FUA
l: sd 1:0:0:0: [sdb] Attached SCSI disk
l: ata2.00: exception Emask 0x0 SAct 0x8 SErr 0x8 action 0x6 frozen
l: ata2.00: failed command: READ FPDMA QUEUED
l: ata2.00: cmd 60/01:18:10:27:00/00:00:00:00:00/40 tag 3 ncq dma 512
in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
l: ata2.00: status: { DRDY }
l: ata2.00: configured for UDMA/100
l: ata2.00: device reported invalid CHS sector 0
l: ata2.00: exception Emask 0x0 SAct 0x4000 SErr 0x4000 action 0x6 frozen
l: ata2.00: failed command: READ FPDMA QUEUED
l: ata2.00: cmd 60/01:70:10:27:00/00:00:00:00:00/40 tag 14 ncq dma 512
in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
l: ata2.00: status: { DRDY }
l: ata2.00: configured for UDMA/100
l: ata2.00: device reported invalid CHS sector 0
l: ata2.00: exception Emask 0x0 SAct 0x80000000 SErr 0x80000000 action
0x6 frozen
l: ata2.00: failed command: READ FPDMA QUEUED
l: ata2.00: cmd 60/01:f8:10:27:00/00:00:00:00:00/40 tag 31 ncq dma 512
in res 40/00:ff:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
l: ata2.00: status: { DRDY }
l: ata2.00: configured for UDMA/100
l: ata2.00: NCQ disabled due to excessive errors
l: ata2.00: exception Emask 0x0 SAct 0x40000 SErr 0x40000 action 0x6
frozen
l: ata2.00: failed command: READ FPDMA QUEUED
l: ata2.00: cmd 60/01:90:10:27:00/00:00:00:00:00/40 tag 18 ncq dma 512
in res 40/00:01:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
l: ata2.00: status: { DRDY }
l: ata2.00: configured for UDMA/100
$ journalctl -b _KERNEL_DURABLE_NAME="`cat /sys/block/nvme0n1/wwid`"
| cut -c 25- | fmt -t
l: blk_update_request: critical medium error, dev nvme0n1, sector 10000
op 0x0:(READ) flags 0x80700 phys_seg 4 prio class 0
l: blk_update_request: critical medium error, dev nvme0n1, sector 10000
op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
l: Buffer I/O error on dev nvme0n1, logical block 1250, async page read
$ journalctl -b _KERNEL_DURABLE_NAME="`cat /sys/block/sdc/device/wwid`"
| cut -c 25- | fmt -t
l: sd 8:0:0:0: Power-on or device reset occurred
l: sd 8:0:0:0: [sdc] 16777216 512-byte logical blocks: (8.59 GB/8.00 GiB)
l: sd 8:0:0:0: Attached scsi generic sg2 type 0
l: sd 8:0:0:0: [sdc] Write Protect is off
l: sd 8:0:0:0: [sdc] Mode Sense: 63 00 00 08
l: sd 8:0:0:0: [sdc] Write cache: enabled, read cache: enabled, doesn't
support DPO or FUA
l: sd 8:0:0:0: [sdc] Attached SCSI disk
l: sd 8:0:0:0: [sdc] tag#255 FAILED Result: hostbyte=DID_OK
driverbyte=DRIVER_SENSE cmd_age=0s
l: sd 8:0:0:0: [sdc] tag#255 Sense Key : Medium Error [current]
l: sd 8:0:0:0: [sdc] tag#255 Add. Sense: Unrecovered read error
l: sd 8:0:0:0: [sdc] tag#255 CDB: Read(10) 28 00 00 00 27 10 00 00 01 00
l: blk_update_request: critical medium error, dev sdc, sector 10000 op
0x0:(READ) flags 0x0 phys_seg 1 prio class 0
There should be no changes to the log message content with this patch series.
I ran release kernel and this patch series and did a compare while forcing the
kernel through the same errors paths to verify.
The first 6 commits in the patch series utilize changes needed for dev_printk
code path. The last 6 commits in the patch add the needed changes to utilize
durable_name_printk. The function durable_name_printk is nothing more than
a printk that adds structured key/value durable name to unmodified printk
output. I structured it this way so only a subset of the patch series could
be theoretically applied if we cannot get agreement on complete patch series.
v2:
- Incorporated changes suggested by James Bottomley
- Removed string function which removed leading/trailing/duplicate adjacent
spaces from generated id, value matches /sys/block/<device>/device/wwid
- Remove xfs patch, limiting changes to lower block layers
- Moved callback from struct device_type to struct device. Struct device_type
is typically static const and with a number of different areas using shared
implementation of genhd unable to modify for each of the different areas.
v3:
- Increase the size of the buffers for NVMe id generation and
dev_vprintk_emit
v4:
- Back out dev_printk for those locations that weren't using it before, so that
we don't change the content of the user visible log message by using a
function durable_name_printk.
- Remove RFC from patch series.
v5:
- Reduced stack usage for nvme wwid
- Make function ata_scsi_durable_name static, found by kernel test robot
- Incorporated suggested changes from Andy Shevchenko and Sergei Shtylyov
* Remove unneeded line spacing
* Correct spelling
* Remove unneeded () in conditional operator
* Re-worked expressions to follow common kernel patterns, added
function dev_to_scsi_device
- Re-based for v5.8 branch
Tony Asleson (12):
struct device: Add function callback durable_name
create_syslog_header: Add durable name
dev_vprintk_emit: Increase hdr size
scsi: Add durable_name for dev_printk
nvme: Add durable name for dev_printk
libata: Add ata_scsi_durable_name
libata: Make ata_scsi_durable_name static
Add durable_name_printk
libata: use durable_name_printk
Add durable_name_printk_ratelimited
print_req_error: Use durable_name_printk_ratelimited
buffer_io_error: Use durable_name_printk_ratelimited
block/blk-core.c | 5 ++++-
drivers/ata/libata-core.c | 17 +++++++-------
drivers/ata/libata-scsi.c | 18 ++++++++++++---
drivers/base/core.c | 46 +++++++++++++++++++++++++++++++++++++-
drivers/nvme/host/core.c | 18 +++++++++++++++
drivers/scsi/scsi_lib.c | 9 ++++++++
drivers/scsi/scsi_sysfs.c | 35 +++++++++++++++++++++++------
drivers/scsi/sd.c | 2 ++
fs/buffer.c | 15 +++++++++----
include/linux/dev_printk.h | 14 ++++++++++++
include/linux/device.h | 4 ++++
include/scsi/scsi_device.h | 3 +++
12 files changed, 162 insertions(+), 24 deletions(-)
base-commit: bcf876870b95592b52519ed4aafcf9d95999bc9c
--
2.26.2
