David Miller <davem@xxxxxxxxxxxxx> writes: > From: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > Date: Thu, 17 Sep 2020 22:01:00 +1000 > >> Wang Wensheng <wangwensheng4@xxxxxxxxxx> writes: >>> Build the object file with `C=2` and get the following warnings: >>> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- >>> make C=2 drivers/ide/pmac.o ARCH=powerpc64 >>> CROSS_COMPILE=powerpc64-linux-gnu- >>> >>> drivers/ide/pmac.c:228:23: warning: symbol 'mdma_timings_33' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:241:23: warning: symbol 'mdma_timings_33k' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:254:23: warning: symbol 'mdma_timings_66' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:272:3: warning: symbol 'kl66_udma_timings' was not >>> declared. Should it be static? >>> drivers/ide/pmac.c:1418:12: warning: symbol 'pmac_ide_probe' was not >>> declared. Should it be static? >>> >>> Signed-off-by: Wang Wensheng <wangwensheng4@xxxxxxxxxx> >>> --- >>> drivers/ide/pmac.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> TIL davem maintains IDE? >> >> But I suspect he isn't that interested in this powerpc only driver, so >> I'll grab this. > > I did have it in my queue, but if you want to take it that's fine too :) That's OK, if you've got it already you take it. Thanks. cheers