Hello Rob Herring, Thanks for review. Regards, Piyush Mehta -----Original Message----- From: Rob Herring <robh@xxxxxxxxxx> Sent: Tuesday, September 15, 2020 1:39 AM To: Piyush Mehta <piyushm@xxxxxxxxxx> Cc: axboe@xxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>; Srinivas Goud <sgoud@xxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx> Subject: Re: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation for CEVA Controller On Wed, Sep 02, 2020 at 12:35:48PM +0530, Piyush Mehta wrote: > This patch updates the documentation for the CEVA controller for > adding the required properties for 'phys' and 'resets'. > > Signed-off-by: Piyush Mehta <piyush.mehta@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/ata/ahci-ceva.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt > b/Documentation/devicetree/bindings/ata/ahci-ceva.txt > index 7561cc4..f01d317 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt > @@ -35,6 +35,10 @@ Required properties: > ceva,pN-retry-params = /bits/ 16 <RIT RCT>; > RIT: Retry Interval Timer. > RCT: Rate Change Timer. > + - phys: phandle for the PHY device > + - phy-names: Should be "sata-phy" > + - resets: phandle to the reset controller for the SATA IP > + - reset-names: Should be "sata_rst". The names here are rather pointless. You don't really need them if only 1 entry. > > Optional properties: > - ceva,broken-gen2: limit to gen1 speed instead of gen2. > @@ -56,4 +60,8 @@ Examples: > ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>; > ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>; > ceva,broken-gen2; > + phy-names = "sata-phy"; > + phys = <&psgtr 1 PHY_TYPE_SATA 1 1>; > + reset-names = "sata_rst"; > + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>; > }; > -- > 2.7.4 >
