On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: > On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > > On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: > >> On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > >>> The patch is compile-tested only. > >> > >> Please test and verify actual functionality, if you're serious about > >> potentially getting this into the kernel. > >> > > Hello Jens, > > > > Sadly I don't have the hardware. This upgrade is part of my Linux Kernel > > Mentorship Program project. Like other PCI drivers which I have updated, I could > > do compile-testing only. Though this patch covers 54 drivers but the actual > > change is done only in drivers/ata/libata-core. Since rest of the drivers > > make use of the same ata_pci_device_suspend/resume(), it was a chain reaction. I > > only had to change variable binding in "struct pci_driver" variable of dependent > > drivers. > > That's understandable, but you should find at least some hardware (maybe remotely > accessible) to test this on. I'm not going to apply this without some confidence > that it actually works, and compile only testing is a far cry from that. Lots of > code compiles, but fails miserably at runtime. > > While it's touching 54 drivers, at least basic coverage of the most popular > choices will give everybody some confidence that it works in general. > Yes, I agree. Actually with previous drivers, I was able to get help from maintainers and/or supporters for the hardware testing. Is that possible for this patch? Thanks Vaibhav Gupta > -- > Jens Axboe >
