On Sat, Jul 25, 2020 at 09:00:12AM +0800, kernel test robot wrote: > Hi Vaibhav, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on block/for-next] > [also build test WARNING on v5.8-rc6 next-20200724] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/ata-use-generic-power-management/20200724-190929 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > config: x86_64-allyesconfig (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1d09ecf36175f7910ffedd6d497c07b5c74c22fb) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > >> drivers/ata/pata_triflex.c:186:36: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement] > static const struct ata_port_info info = { > ^ > 1 warning generated. > > vim +186 drivers/ata/pata_triflex.c > > 669a5db411d85a Jeff Garzik 2006-08-29 176 > 669a5db411d85a Jeff Garzik 2006-08-29 177 static int triflex_init_one(struct pci_dev *dev, const struct pci_device_id *id) > 669a5db411d85a Jeff Garzik 2006-08-29 178 { > 5acd74b592933f Vaibhav Gupta 2020-07-24 179 /* > 5acd74b592933f Vaibhav Gupta 2020-07-24 180 * We must not disable or powerdown the device. > 5acd74b592933f Vaibhav Gupta 2020-07-24 181 * APM bios refuses to suspend if IDE is not accessible. > 5acd74b592933f Vaibhav Gupta 2020-07-24 182 */ > 5acd74b592933f Vaibhav Gupta 2020-07-24 183 dev->pm_cap = 0; > 5acd74b592933f Vaibhav Gupta 2020-07-24 184 dev_info(&dev->dev, "Disable triflex to be turned off by PCI CORE\n"); > 5acd74b592933f Vaibhav Gupta 2020-07-24 185 > 1626aeb881236c Tejun Heo 2007-05-04 @186 static const struct ata_port_info info = { > 1d2808fd3d2d5d Jeff Garzik 2007-05-28 187 .flags = ATA_FLAG_SLAVE_POSS, > 14bdef982caeda Erik Inge Bolsø 2009-03-14 188 .pio_mask = ATA_PIO4, > 14bdef982caeda Erik Inge Bolsø 2009-03-14 189 .mwdma_mask = ATA_MWDMA2, > 669a5db411d85a Jeff Garzik 2006-08-29 190 .port_ops = &triflex_port_ops > 669a5db411d85a Jeff Garzik 2006-08-29 191 }; > 1626aeb881236c Tejun Heo 2007-05-04 192 const struct ata_port_info *ppi[] = { &info, NULL }; > 669a5db411d85a Jeff Garzik 2006-08-29 193 > 06296a1e684bcd Joe Perches 2011-04-15 194 ata_print_version_once(&dev->dev, DRV_VERSION); > 669a5db411d85a Jeff Garzik 2006-08-29 195 > 1c5afdf7a629d2 Tejun Heo 2010-05-19 196 return ata_pci_bmdma_init_one(dev, ppi, &triflex_sht, NULL, 0); > 669a5db411d85a Jeff Garzik 2006-08-29 197 } > 669a5db411d85a Jeff Garzik 2006-08-29 198 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Fixed in v2. Will float v2 after few more checks. Thanks Vaibhav Gupta
