On 02/04/2020 07:30, YueHaibing wrote:
+
If SATA_HOST is n, build fails:
drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd':
hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis'
Select SATA_HOST to fix this.
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Fixes: 7c594f0407de ("scsi: hisi_sas: add softreset function for SATA disk")
That's not right. SATA_HOST was only introduced recently in the ATA
code. It would fix those kconfig changes.
Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
---
drivers/scsi/hisi_sas/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
index 90a17452a50d..13ed9073fc72 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -6,6 +6,7 @@ config SCSI_HISI_SAS
select SCSI_SAS_LIBSAS
select BLK_DEV_INTEGRITY
depends on ATA
+ select SATA_HOST
That does not feel right.
SCSI_HISI_SAS depends on ATA, but SATA_HOST also depends on ATA, so it
seems better to just depend on SATA_HOST (and omit explicit ATA
dependency), rather than select it.
Thanks,
John
