On Tue, Mar 17, 2020 at 03:43:29PM +0100, Bartlomiej Zolnierkiewicz wrote: > Start separating SATA specific code from libata-scsi.c: > > * un-static ata_scsi_find_dev() > > * move following code to libata-sata.c: > - SATA only sysfs device attributes handling > - __ata_change_queue_depth() > - ata_scsi_change_queue_depth() > > * cover with CONFIG_SATA_HOST ifdef SATA only sysfs device > attributes handling code and ATA_SHT_NCQ() macro in > <linux/libata.h> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>