On Tue, Mar 17, 2020 at 03:43:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > * move sata_link_{debounce,resume}() to libata-sata.c > > * add static inline for CONFIG_SATA_HOST=n case (only one, > for sata_link_resume() is needed) This looks good for now: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But as a follow on I think it would make sene to just split ata_std_prereset into a pata and a sata version, and then we don't even need the non-static and potentially stubeed out sata_link_resume.