Re: [PATCH v4 14/27] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
Subject: Re: [PATCH v4 14/27] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 26 Mar 2020 10:50:23 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, Michael Schmitz <schmitzmic@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-ide@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20200317144333.2904-15-b.zolnierkie@samsung.com>
References: <20200317144333.2904-1-b.zolnierkie@samsung.com> <CGME20200317144348eucas1p14ad861316b19edaf885a52f9beb5dd2a@eucas1p1.samsung.com> <20200317144333.2904-15-b.zolnierkie@samsung.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Mar 17, 2020 at 03:43:20PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Add !IS_ENABLED(CONFIG_SATA_HOST) to ata_dev_config_ncq() to allow
> compiler to optimize out the function for non-SATA configs.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v4 00/27] ata: optimize core code size on PATA only setups
  - From: Bartlomiej Zolnierkiewicz
- [PATCH v4 14/27] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts
  - From: Bartlomiej Zolnierkiewicz

Prev by Date: Re: [PATCH v4 13/27] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()
Next by Date: Re: [PATCH v4 15/27] ata: let compiler optimize out ata_eh_set_lpm() on non-SATA hosts
Previous by thread: [PATCH v4 14/27] ata: let compiler optimize out ata_dev_config_ncq() on non-SATA hosts
Next by thread: [PATCH v4 13/27] ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems] [Linux SCSI] [Linux RAID] [Git] [Kernel Newbies] [Linux Newbie] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Samba] [Device Mapper]