On Tue, Mar 17, 2020 at 03:43:08PM +0100, Bartlomiej Zolnierkiewicz wrote: > There is no point in exposing ncq_enable_prio sysfs attribute for > devices on PATA and non-NCQ capable SATA hosts so: > > * remove dev_attr_ncq_prio_enable from ata_common_sdev_attrs[] > > * add ata_ncq_sdev_attrs[] > > * update ATA_NCQ_SHT() macro to use ata_ncq_sdev_attrs[] > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>