Re: [PATCH] sata_fsl: build fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/25/20 5:25 PM, Bartlomiej Zolnierkiewicz wrote:

On 3/25/20 4:17 PM, Jens Axboe wrote:
On 3/25/20 9:15 AM, Bartlomiej Zolnierkiewicz wrote:
Fix incorrect DPRINTK() conversion in sata_fsl_init_controller()
(dev_dbg() should be used instead of ata_port_dbg()).

Thanks Bart, another piece of fallout. Applied.

With the recent discussion as well, I wonder if we should just kill
this series entirely.
I hate to admit it but probably yes..

It seems that the one of base concepts needs to be redesigned and
we are at -rc7 so it is a bit too late do it now..

I've also tried to find a way to revert it partially but changes are
inter-dependent and it doesn't seem to be easy way to do it..

Hannes?

Seeing that we are late in the game and the dev_printk() fallacies are indeed there I fear that you are correct.
Jens, again, sorry for the mess.

Cheers,

Hannes
--
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@xxxxxxx                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux