Hi Hannes,
On Tue, 3 Mar 2020, Hannes Reinecke wrote:
Use standard dev_{dbg,info,notice,warn,err} macros instead of the
hand-crafted printk helpers.
Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
This is now commit ad9f23bd12e1d721 ("libata: move
ata_{port,link,dev}_dbg to standard dev_XXX() macros") in
linux-block/for-next.
This patch causes an intriguing change in boot messages, adding a space
at the beginning of each printed line:
scsi host0: sata_rcar
-ata1: SATA max UDMA/133 irq 117
+ ata1: SATA max UDMA/133 irq 117
-ata1: link resume succeeded after 1 retries
+ link1: link resume succeeded after 1 retries
-ata1: SATA link down (SStatus 0 SControl 300)
+ link1: SATA link down (SStatus 0 SControl 300)
It turns out dev_driver_string(&link->tdev) returns an empty string, as
its driver field is NULL, so __dev_printk() prints the empty string and
the device name, separated by a space.
At first I thought this was a bug in rcar-sata, lacking some setup that
was harmless before, but it turns out other drivers (e.g. pata-falcon)
show the same issue:
scsi host0: pata_falcon
-ata1: PATA max PIO4 cmd 0xfff00000 ctl 0xfff00039
+ ata1: PATA max PIO4 cmd 0xfff00000 ctl 0xfff00039
-ata1.01: NODEV after polling detection
-ata1.00: ATA-2: Sarge m68k, , max PIO2
-ata1.00: 2118816 sectors, multi 0: LBA
-ata1.00: configured for PIO
+ dev1.0: ATA-2: Sarge m68k, , max PIO2
+ dev1.0: 2118816 sectors, multi 0: LBA
+ dev1.0: configured for PIO
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
