Re: 回复:[PATCH 1/6] PCI: Add Loongson vendor ID and 7A1000 device IDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/09/2020 04:50 PM, Jiaxun Yang wrote:
  ---- 在 星期一, 2020-03-09 16:23:21 Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> 撰写 ----
  > Add the Loongson vendor ID and 7A1000 device IDs to pci_ids.h
  > to be used by the controller driver in the future.
  >
  > The Loongson IDs can be found at the following link:
  > https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids
  >
  > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
  > ---
  >  include/linux/pci_ids.h | 18 ++++++++++++++++++
  >  1 file changed, 18 insertions(+)
  >
  > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
  > index 352c0d7..0125ab4 100644
  > --- a/include/linux/pci_ids.h
  > +++ b/include/linux/pci_ids.h
  > @@ -3113,4 +3113,22 @@
  >
  >  #define PCI_VENDOR_ID_NCUBE        0x10ff
  >
  > +#define PCI_VENDOR_ID_LOONGSON            0x0014
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HT    0x7a00
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_APB    0x7a02
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GMAC    0x7a03
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OTG    0x7a04
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DC    0x7a06
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HDA    0x7a07
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SATA    0x7a08
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X1    0x7a09
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SPI    0x7a0b
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_LPC    0x7a0c
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DMA    0x7a0f
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_EHCI    0x7a14
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GPU    0x7a15
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X4    0x7a19
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OHCI    0x7a24
  > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X8    0x7a29

Devices IDs are unlikely to be reused by mutiple subsystems, so probably we don't need
to add them here?

Hi Jiaxun,

I think it is better to define the device IDs in pci_ids.h,
otherwise it seems a little disorganized.

Thanks,

Tiezhu Yang

+
  >  #endif /* _LINUX_PCI_IDS_H */
  > --
  > 2.1.0
  >
  >




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux