Re: [PATCH 11/42] libata: sanitize ATA_HORKAGE_DUMP_ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/13/20 10:53 AM, Hannes Reinecke wrote:
> As ata_dev_dbg() is now using dynamic debugging ATA_HORKAGE_DUMP_ID
> will now print out the raw IDENTIFY data without a header unless
> explicitly enable via dyndebug.
> So move the logging level up to INFO and have the header printed
> always.
> 
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/ata/libata-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 1987886140b6..40e327e49905 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -1944,10 +1944,10 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class,
>  	}
>  
>  	if (dev->horkage & ATA_HORKAGE_DUMP_ID) {
> -		ata_dev_dbg(dev, "dumping IDENTIFY data, "
> +		ata_dev_info(dev, "dumping IDENTIFY data, "
>  			    "class=%d may_fallback=%d tried_spinup=%d\n",
>  			    class, may_fallback, tried_spinup);
> -		print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET,
> +		print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET,
>  			       16, 2, id, ATA_ID_WORDS * sizeof(*id), true);
>  	}
>  
> 



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux