On 2/13/20 10:53 AM, Hannes Reinecke wrote: > Replace DPRINTK calls with tracepoints. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/ata/libata-sff.c | 5 +---- > include/trace/events/libata.h | 25 +++++++++++++++++++++++++ > 2 files changed, 26 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c > index f6a54b574b25..ffe633f13f55 100644 > --- a/drivers/ata/libata-sff.c > +++ b/drivers/ata/libata-sff.c > @@ -1234,7 +1234,7 @@ EXPORT_SYMBOL_GPL(ata_sff_queue_pio_task); > > void ata_sff_flush_pio_task(struct ata_port *ap) > { > - DPRINTK("ENTER\n"); > + trace_ata_sff_flush_pio_task(ap); > > cancel_delayed_work_sync(&ap->sff_pio_task); > > @@ -1251,9 +1251,6 @@ void ata_sff_flush_pio_task(struct ata_port *ap) > spin_unlock_irq(ap->lock); > > ap->sff_pio_task_link = NULL; > - > - if (ata_msg_ctl(ap)) > - ata_port_dbg(ap, "EXIT\n"); > } > > static void ata_sff_pio_task(struct work_struct *work) > diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h > index a4200ef943f3..bebde8a72b9c 100644 > --- a/include/trace/events/libata.h > +++ b/include/trace/events/libata.h > @@ -617,6 +617,31 @@ DEFINE_EVENT(ata_transfer_data_template, atapi_send_cdb, > TP_PROTO(struct ata_queued_cmd *qc, unsigned int offset, unsigned int count), > TP_ARGS(qc, offset, count)); > > +DECLARE_EVENT_CLASS(ata_sff_template, > + > + TP_PROTO(struct ata_port *ap), > + > + TP_ARGS(ap), > + > + TP_STRUCT__entry( > + __field( unsigned int, ata_port ) > + __field( unsigned char, hsm_state ) > + ), > + > + TP_fast_assign( > + __entry->ata_port = ap->print_id; > + __entry->hsm_state = ap->hsm_task_state; > + ), > + > + TP_printk("ata_port=%u task_state=%s", > + __entry->ata_port, > + show_sff_hsm_state_name(__entry->hsm_state)) > +); > + > +DEFINE_EVENT(ata_sff_template, ata_sff_flush_pio_task, > + TP_PROTO(struct ata_port *ap), > + TP_ARGS(ap)); > + > #endif /* _TRACE_LIBATA_H */ > > /* This part must be outside protection */ >