On 2/13/20 10:53 AM, Hannes Reinecke wrote:
> Remove logging messages covered by generic tracepoints and add
> generic tracepoints for internal calls.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/sata_nv.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
> index 8639f66706a3..f7dd32679c8e 100644
> --- a/drivers/ata/sata_nv.c
> +++ b/drivers/ata/sata_nv.c
> @@ -31,6 +31,7 @@
> #include <scsi/scsi_host.h>
> #include <scsi/scsi_device.h>
> #include <linux/libata.h>
> +#include <trace/events/libata.h>
>
> #define DRV_NAME "sata_nv"
> #define DRV_VERSION "3.5"
> @@ -1428,8 +1429,6 @@ static unsigned int nv_adma_qc_issue(struct ata_queued_cmd *qc)
>
> writew(qc->hw_tag, mmio + NV_ADMA_APPEND);
>
> - DPRINTK("Issued tag %u\n", qc->hw_tag);
> -
> return 0;
> }
>
> @@ -2007,19 +2006,17 @@ static unsigned int nv_swncq_issue_atacmd(struct ata_port *ap,
> if (qc == NULL)
> return 0;
>
> - DPRINTK("Enter\n");
> -
> writel((1 << qc->hw_tag), pp->sactive_block);
> pp->last_issue_tag = qc->hw_tag;
> pp->dhfis_bits &= ~(1 << qc->hw_tag);
> pp->dmafis_bits &= ~(1 << qc->hw_tag);
> pp->qc_active |= (0x1 << qc->hw_tag);
>
> + trace_ata_tf_load(ap, &qc->tf);
> ap->ops->sff_tf_load(ap, &qc->tf); /* load tf registers */
> + trace_ata_exec_command(ap, &qc->tf, qc->hw_tag);
> ap->ops->sff_exec_command(ap, &qc->tf);
>
> - DPRINTK("Issued tag %u\n", qc->hw_tag);
> -
> return 0;
> }
>
> @@ -2031,8 +2028,6 @@ static unsigned int nv_swncq_qc_issue(struct ata_queued_cmd *qc)
> if (qc->tf.protocol != ATA_PROT_NCQ)
> return ata_bmdma_qc_issue(qc);
>
> - DPRINTK("Enter\n");
> -
> if (!pp->qc_active)
> nv_swncq_issue_atacmd(ap, qc);
> else
>
