On 2/13/20 10:53 AM, Hannes Reinecke wrote: > Add missing bmdma tracepoints and drop the now pointless > DPRINTK() calls. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/ata/pata_octeon_cf.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c > index 9b66552efbd2..62646dbc9d71 100644 > --- a/drivers/ata/pata_octeon_cf.c > +++ b/drivers/ata/pata_octeon_cf.c > @@ -19,7 +19,7 @@ > #include <linux/of_platform.h> > #include <linux/platform_device.h> > #include <scsi/scsi_host.h> > - > +#include <trace/events/libata.h> > #include <asm/byteorder.h> > #include <asm/octeon/octeon.h> > > @@ -535,12 +535,10 @@ static void octeon_cf_dma_setup(struct ata_queued_cmd *qc) > struct octeon_cf_port *cf_port; > > cf_port = ap->private_data; > - DPRINTK("ENTER\n"); > /* issue r/w command */ > qc->cursg = qc->sg; > cf_port->dma_finished = 0; > ap->ops->sff_exec_command(ap, &qc->tf); > - DPRINTK("EXIT\n"); > } > > /** > @@ -792,8 +790,11 @@ static unsigned int octeon_cf_qc_issue(struct ata_queued_cmd *qc) > case ATA_PROT_DMA: > WARN_ON(qc->tf.flags & ATA_TFLAG_POLLING); > > + trace_ata_tf_load(ap, &qc->tf); > ap->ops->sff_tf_load(ap, &qc->tf); /* load tf registers */ > + trace_ata_bmdma_setup(ap, &qc->tf, qc->tag); > octeon_cf_dma_setup(qc); /* set up dma */ > + trace_ata_bmdma_start(ap, &qc->tf, qc->tag); > octeon_cf_dma_start(qc); /* initiate dma */ > ap->hsm_task_state = HSM_ST_LAST; > break; >