On 2/13/20 10:54 AM, Hannes Reinecke wrote:
> Replace all DPRINTK calls with the ata_XXX_dbg functions.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/sata_nv.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
> index f7dd32679c8e..0bdf18625d95 100644
> --- a/drivers/ata/sata_nv.c
> +++ b/drivers/ata/sata_nv.c
> @@ -2094,7 +2094,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
> ata_qc_complete_multiple(ap, ap->qc_active ^ done_mask);
>
> if (!ap->qc_active) {
> - DPRINTK("over\n");
> + ata_port_dbg(ap, "over\n");
> nv_swncq_pp_reinit(ap);
> return 0;
> }
> @@ -2109,10 +2109,10 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
> */
> lack_dhfis = 1;
>
> - DPRINTK("id 0x%x QC: qc_active 0x%x,"
> + ata_port_dbg(ap, "QC: qc_active 0x%llx,"
> "SWNCQ:qc_active 0x%X defer_bits %X "
> "dhfis 0x%X dmafis 0x%X last_issue_tag %x\n",
> - ap->print_id, ap->qc_active, pp->qc_active,
> + ap->qc_active, pp->qc_active,
> pp->defer_queue.defer_bits, pp->dhfis_bits,
> pp->dmafis_bits, pp->last_issue_tag);
>
> @@ -2154,7 +2154,7 @@ static void nv_swncq_dmafis(struct ata_port *ap)
> __ata_bmdma_stop(ap);
> tag = nv_swncq_tag(ap);
>
> - DPRINTK("dma setup tag 0x%x\n", tag);
> + ata_port_dbg(ap, "dma setup tag 0x%x\n", tag);
> qc = ata_qc_from_tag(ap, tag);
>
> if (unlikely(!qc))
> @@ -2222,9 +2222,9 @@ static void nv_swncq_host_interrupt(struct ata_port *ap, u16 fis)
>
> if (fis & NV_SWNCQ_IRQ_SDBFIS) {
> pp->ncq_flags |= ncq_saw_sdb;
> - DPRINTK("id 0x%x SWNCQ: qc_active 0x%X "
> + ata_port_dbg(ap, "SWNCQ: qc_active 0x%X "
> "dhfis 0x%X dmafis 0x%X sactive 0x%X\n",
> - ap->print_id, pp->qc_active, pp->dhfis_bits,
> + pp->qc_active, pp->dhfis_bits,
> pp->dmafis_bits, readl(pp->sactive_block));
> if (nv_swncq_sdbfis(ap) < 0)
> goto irq_error;
> @@ -2250,7 +2250,7 @@ static void nv_swncq_host_interrupt(struct ata_port *ap, u16 fis)
> goto irq_exit;
>
> if (pp->defer_queue.defer_bits) {
> - DPRINTK("send next command\n");
> + ata_port_dbg(ap, "send next command\n");
> qc = nv_swncq_qc_from_dq(ap);
> nv_swncq_issue_atacmd(ap, qc);
> }
>
