On 1/29/20 6:26 PM, Christoph Hellwig wrote: > On Tue, Jan 28, 2020 at 02:33:27PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Start separating SATA specific code from libata-core.c: >> >> * move following functions to libata-core-sata.c: > > Why not call this libata-sata.c? If it is SATA specific it can't be > that core :) Indeed. :) >> + * libata-core-sata.c - SATA specific part of ATA helper library > > No need for file names in top of file headers. > >> +/* >> + * Core layer (SATA specific part) - drivers/ata/libata-core-sata.c >> + */ >> +#ifdef CONFIG_SATA_HOST >> +extern int sata_link_scr_lpm(struct ata_link *link, enum ata_lpm_policy policy, >> + bool spm_wakeup); >> +extern int ata_slave_link_init(struct ata_port *ap); >> +extern void ata_tf_to_fis(const struct ata_taskfile *tf, >> + u8 pmp, int is_cmd, u8 *fis); >> +extern void ata_tf_from_fis(const u8 *fis, struct ata_taskfile *tf); >> extern bool sata_lpm_ignore_phy_events(struct ata_link *link); >> +#endif > > No need for the ifdef. All above issues are fixed in v2. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
