Hello!
On 04.02.2020 19:55, Hannes Reinecke wrote:
The bus probe is better tracked with the actual calls, and the
resulting taskfile will be printed with tracepoints anyway.
Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
---
drivers/ata/libata-core.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index cea065fb6282..0f5715cfa1c4 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
[...]
@@ -6475,11 +6472,8 @@ int ata_port_probe(struct ata_port *ap)
if (ap->ops->error_handler) {
__ata_port_probe(ap);
ata_port_wait_eh(ap);
- } else {
- DPRINTK("ata%u: bus probe begin\n", ap->print_id);
+ } else
You shousd keep {} here, according to the CodingStyle. {} should be
used in all branches if used in any.
rc = ata_bus_probe(ap);
- DPRINTK("ata%u: bus probe end\n", ap->print_id);
- }
return rc;
}
MBR, Sergei
