Re: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
Subject: Re: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 29 Jan 2020 09:28:11 -0800
Cc: Jens Axboe <axboe@xxxxxxxxx>, Michael Schmitz <schmitzmic@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20200128133343.29905-14-b.zolnierkie@samsung.com>
References: <20200128133343.29905-1-b.zolnierkie@samsung.com> <CGME20200128133415eucas1p258c0d5c313e2ae42a05508b67eec16ef@eucas1p2.samsung.com> <20200128133343.29905-14-b.zolnierkie@samsung.com>

On Tue, Jan 28, 2020 at 02:33:28PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move ata_do_link_spd_horkage() to libata-core-sata.c
> 
> * add static inline for CONFIG_SATA_HOST=n case

Wouldn't it make more sense to stub out sata_scr_valid for the !SATA
case and just let the compiler optimize the function away now that it
can't be called in that case?

Follow-Ups:
- Re: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c
  - From: Bartlomiej Zolnierkiewicz

References:
- [PATCH 00/28] ata: optimize core code size on PATA only setups
  - From: Bartlomiej Zolnierkiewicz
- [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c
  - From: Bartlomiej Zolnierkiewicz

Prev by Date: Re: [PATCH 12/28] ata: start separating SATA specific code from libata-core.c
Next by Date: Re: [PATCH 14/28] ata: move ata_dev_config_ncq*() to libata-core-sata.c
Previous by thread: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c
Next by thread: Re: [PATCH 13/28] ata: move ata_do_link_spd_horkage() to libata-core-sata.c
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems] [Linux SCSI] [Linux RAID] [Git] [Kernel Newbies] [Linux Newbie] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Samba] [Device Mapper]